Add logging for invalid callbacks

digitalservicebund · Oct 30, 2024 · be4d76e · be4d76e
1 parent a0d9b21
commit be4d76e
Showing 1 changed file with 6 additions and 3 deletions.
diff --git a/src/main/java/de/bund/digitalservice/a2j/service/subscriber/CallbackVerificationFilter.java b/src/main/java/de/bund/digitalservice/a2j/service/subscriber/CallbackVerificationFilter.java
@@ -1,5 +1,6 @@
 package de.bund.digitalservice.a2j.service.subscriber;
 
+import dev.fitko.fitconnect.api.domain.validation.ValidationResult;
 import dev.fitko.fitconnect.client.SenderClient;
 import jakarta.servlet.FilterChain;
 import jakarta.servlet.ServletException;
@@ -42,15 +43,17 @@ protected void doFilterInternal(
     String requestBody =
         new String(wrappedRequest.getContentAsByteArray(), request.getCharacterEncoding());
 
-    if (!senderClient
+    ValidationResult result = senderClient
         .validateCallback(
             request.getHeader("callback-authentication"),
             Long.parseLong(request.getHeader("callback-timestamp")),
             requestBody,
-            callbackSecret)
-        .isValid()) {
+            callbackSecret);
 
+    if (!result.isValid()) {
       logger.info("Received invalid fit-connect callback");
+      logger.info(result.getProblems().toString());
+      logger.info(result.getError().getMessage());
       response.setStatus(HttpServletResponse.SC_UNAUTHORIZED);
       return;
     }