refactor(pdf-service): remove font size changes in pdf form (#1554)

digitalservicebund · Dec 16, 2024 · d64a9ec · d64a9ec
1 parent 9579df3
commit d64a9ec
Show file tree

Hide file tree

Showing 6 changed files with 13 additions and 66 deletions.
diff --git a/app/domains/prozesskostenhilfe/services/pdf/pdfForm/A_person.ts b/app/domains/prozesskostenhilfe/services/pdf/pdfForm/A_person.ts
@@ -3,6 +3,7 @@ import { maritalDescriptionMapping } from "~/domains/shared/services/pdf/marital
 import {
   type AttachmentEntries,
   SEE_IN_ATTACHMENT_DESCRIPTION,
+  SEE_IN_ATTACHMENT_DESCRIPTION_SHORT,
 } from "~/services/pdf/attachment";
 import type { PkhPdfFillFunction } from "..";
 
@@ -73,7 +74,7 @@ export const fillPerson: PkhPdfFillFunction = ({ userData, pdfValues }) => {
       title: "Familienstand",
       text: maritalDescription,
     });
-    pdfValues.text3.value = "s.A.";
+    pdfValues.text3.value = SEE_IN_ATTACHMENT_DESCRIPTION_SHORT;
   } else {
     pdfValues.text3.value = maritalDescription;
   }

diff --git a/app/domains/prozesskostenhilfe/services/pdf/pdfForm/__test__/A_person.test.ts b/app/domains/prozesskostenhilfe/services/pdf/pdfForm/__test__/A_person.test.ts
@@ -4,7 +4,10 @@ import {
 } from "data/pdf/prozesskostenhilfe/prozesskostenhilfe.generated";
 import type { ProzesskostenhilfeFormularContext } from "~/domains/prozesskostenhilfe/formular";
 import { maritalDescriptionMapping } from "~/domains/shared/services/pdf/maritalDescriptionMapping";
-import { SEE_IN_ATTACHMENT_DESCRIPTION } from "~/services/pdf/attachment";
+import {
+  SEE_IN_ATTACHMENT_DESCRIPTION,
+  SEE_IN_ATTACHMENT_DESCRIPTION_SHORT,
+} from "~/services/pdf/attachment";
 import {
   ANSCHRIFT_FIELD_MAX_CHARS,
   BERUF_FIELD_MAX_CHARS,
@@ -138,7 +141,7 @@ describe("A_person", () => {
       pdfValues: pdfParams,
     });
 
-    expect(pdfValues.text3.value).toBe("s.A.");
+    expect(pdfValues.text3.value).toBe(SEE_IN_ATTACHMENT_DESCRIPTION_SHORT);
     expect(attachment?.at(1)?.title).toBe("Familienstand");
     expect(attachment?.at(1)?.text).toBe(maritalDescriptionMapping.yes);
   });

diff --git a/app/services/pdf/__test__/getFontSizeFieldValue.test.ts b/app/services/pdf/__test__/getFontSizeFieldValue.test.ts
diff --git a/app/services/pdf/attachment/index.ts b/app/services/pdf/attachment/index.ts
@@ -5,3 +5,4 @@ export type AttachmentEntries = {
 }[];
 
 export const SEE_IN_ATTACHMENT_DESCRIPTION = "Siehe Anhang";
+export const SEE_IN_ATTACHMENT_DESCRIPTION_SHORT = "s.A.";
diff --git a/app/services/pdf/getFontSizeFieldValue.ts b/app/services/pdf/getFontSizeFieldValue.ts
diff --git a/app/services/pdf/pdf.server.ts b/app/services/pdf/pdf.server.ts
@@ -1,6 +1,7 @@
 import type { PDFForm } from "pdf-lib";
 import type { BooleanField, StringField } from "./fileTypes";
-import { getFontSizeFieldValue } from "./getFontSizeFieldValue";
+
+const FONT_SIZE_DEFAULT = 10;
 
 export function changeBooleanField(booleanField: BooleanField, form: PDFForm) {
   if (!booleanField.value) return;
@@ -10,10 +11,9 @@ export function changeBooleanField(booleanField: BooleanField, form: PDFForm) {
 export function changeStringField(stringField: StringField, form: PDFForm) {
   if (!stringField.value) return;
   const formField = form.getTextField(stringField.name);
-  // We override the restriction of a field where it is set to have max length of 2.
-  // This is because it impacts letter spacing e.g. in the fourth column of "G_ausgaben".
+  // maxLength property is overridden, because some fields have a max length of 2 even though the field width is greater
   formField.setMaxLength();
   formField.setText(stringField.value);
-  const fontSize = getFontSizeFieldValue(stringField.name);
-  formField.setFontSize(fontSize);
+  // fontSize property is set to a default, because some fields have 0 for auto scale which is bad UX/UI
+  formField.setFontSize(FONT_SIZE_DEFAULT);
 }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,3 +5,4 @@ export type AttachmentEntries = {
		}[];

		export const SEE_IN_ATTACHMENT_DESCRIPTION = "Siehe Anhang";
		export const SEE_IN_ATTACHMENT_DESCRIPTION_SHORT = "s.A.";