fix(pdf-service): styling fixes after move to pdfkit #1530
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spencer6497
approved these changes
Dec 9, 2024
Comment on lines
+34
to
36
| expect.any(Number), | ||
| expect.any(Number), | ||
| expect.any(Object), |
There was a problem hiding this comment.
I'm a bit confused on what this code is actually asserting? Why do we need these here?
There was a problem hiding this comment.
The pdfs for abgabeArt ausdrucken and online are not the same. They have slightly different content. The test is asserting that some of the relevant content is actually fed into the methods composing the pdf. The two lines you've highlighted are arguments of the list method (x and y position). But only the first argument is relevant, hence the arbitrary expect.any(Number).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1203259475859667/1208782862325370