chore(update Freibetraege for 2024) #1533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace magic strings and update tests
… actual, current year is
rbrtrfl
approved these changes
Dec 9, 2024
app/domains/beratungshilfe/vorabcheck/__test__/freibetrag.test.ts
Outdated
Show resolved
Hide resolved
| childrenBelow6Allowance: number; | ||
| }; | ||
|
|
||
| export const BASE_ALLOWANCE = 572; |
There was a problem hiding this comment.
question: when do you use SCREAMING_SNAKE_CASE and when camelCase for the constants?
There was a problem hiding this comment.
SCREAMING_SNAKE_CASE should be used for top-level or global constants, and camelCase should be used for scoped constants (imo, happy to entertain other paradigms :))
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR simplifies and updates the Freibetrag for PKH/BerH by simplifying the interfaces, converting magic strings into constants, and moving year-by-year Freibetraege logic to a map for easy updates.