fix(pdf-service): fix bug with German umlauts not rendered correctly in pdf #1535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Spencer Peace <[email protected]>
chohner
approved these changes
Dec 9, 2024
|
aaschlote
approved these changes
Dec 9, 2024
There is the one arc browser. Never heard of it before this bug: https://arc.net/ |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I could only reproduce this bug with the arc browser. The root cause were two titles in
bargeldandwertsachenwhere the 'ü' ofEigentümer:inwas written as a NFD (normalized form canonical decomposition) which means the 'u' was typed first, followed by the combining diacritical marks.pdfkitdoes not seem to properly support encoding these characters in few cases (arc browser).Proposal: Added a linter rule that detects NFDs.
https://app.asana.com/0/1203259475859667/1208834671333919