Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sidebar navigation): update sidebar navigation styling #1649

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

feat(sidebar navigation): update sidebar navigation styling #1649

wants to merge 5 commits into from
+22 −22

Conversation

ingriddorioschulze
Copy link
Contributor

@ingriddorioschulze ingriddorioschulze commented Jan 23, 2025 •
edited
Loading

This PR contains the new sidebar navigation styling:

  • CheckIcon was replaced by CheckCircle
  • CheckCircle is now positioned on the right side after the label
  • Colors, borders Styling were changed according to states

Before

Screenshot 2025-01-23 at 17 19 32

After

Screenshot 2025-01-23 at 13 58 38

@aaschlote
Copy link
Contributor

aaschlote commented Jan 23, 2025 •
edited
Loading

@ingriddorioschulze can you check the possibility to add some unit tests? I'm aware the tests don't exist at the moment, but it would be cool to start to have some unit tests for non existing components 😃

Spencer6497
Spencer6497 approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@Spencer6497 Spencer6497 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 👍 Could you add side-by-side before-screenshots for comparison? A bit hard to parse the css differences 😅

pgurusinga
pgurusinga approved these changes Jan 24, 2025
View reviewed changes
Copy link
Member

@pgurusinga pgurusinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow nice! 🎉
also +1 for the component testing 🙏

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
72.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Spencer6497 Spencer6497 Spencer6497 approved these changes

@pgurusinga pgurusinga pgurusinga approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ingriddorioschulze @aaschlote @pgurusinga @Spencer6497