Conditional button display, based on status

RISDEV-5139
digitalservicebund · Oct 18, 2024 · adfd16a · adfd16a
1 parent c6dda33
commit adfd16a
Show file tree

Hide file tree

Showing 3 changed files with 81 additions and 12 deletions.
diff --git a/frontend/src/components/DocumentUnitList.vue b/frontend/src/components/DocumentUnitList.vue
@@ -17,6 +17,7 @@ import TableView from "@/components/TableView.vue"
 import { useStatusBadge } from "@/composables/useStatusBadge"
 import { ResponseError } from "@/services/httpClient"
 import IconAttachedFile from "~icons/ic/baseline-attach-file"
+import IconCheck from "~icons/ic/baseline-check"
 import IconDelete from "~icons/ic/baseline-close"
 import IconError from "~icons/ic/baseline-error"
 import IconSubject from "~icons/ic/baseline-subject"
@@ -214,7 +215,26 @@ function onDelete() {
         </CellItem>
         <CellItem class="flex">
           <div class="float-end flex">
-            <Tooltip v-if="listEntry.isEditable" text="Bearbeiten">
+            <Tooltip
+              v-if="
+                listEntry.status?.publicationStatus ==
+                'EXTERNAL_HANDOVER_PENDING'
+              "
+              text="Übernehmen"
+            >
+              <router-link
+                aria-label="Dokumentationseinheit übernehmen"
+                class="flex cursor-pointer border-2 border-r-0 border-solid border-blue-800 p-4 text-blue-800 hover:bg-blue-200 focus-visible:outline focus-visible:outline-4 focus-visible:outline-offset-4 focus-visible:outline-blue-800 active:border-blue-200 active:bg-blue-200"
+                target="_blank"
+                :to="{
+                  name: 'caselaw-documentUnit-documentNumber-categories',
+                  params: { documentNumber: listEntry.documentNumber },
+                }"
+              >
+                <IconCheck />
+              </router-link>
+            </Tooltip>
+            <Tooltip v-else-if="listEntry.isEditable" text="Bearbeiten">
               <router-link
                 aria-label="Dokumentationseinheit bearbeiten"
                 class="flex cursor-pointer border-2 border-r-0 border-solid border-blue-800 p-4 text-blue-800 hover:bg-blue-200 focus-visible:outline focus-visible:outline-4 focus-visible:outline-offset-4 focus-visible:outline-blue-800 active:border-blue-200 active:bg-blue-200"

diff --git a/frontend/test/components/documentUnit/documentUnitList.spec.ts b/frontend/test/components/documentUnit/documentUnitList.spec.ts
@@ -235,4 +235,35 @@ describe("documentUnit list", () => {
       screen.queryByRole("button", { name: "Dokumentationseinheit löschen" }),
     ).not.toBeInTheDocument()
   })
+
+  test("shows 'Übernehmen' icon instead if edit icon, if status equals EXTERNAL_HANDOVER_PENDING", async () => {
+    renderComponent({
+      documentUnitListEntries: [
+        {
+          id: "id",
+          uuid: "1",
+          documentNumber: "123",
+          decisionDate: "2022-02-10",
+          fileNumber: "",
+          documentType: { label: "Test", jurisShortcut: "T" },
+          court: { type: "typeA", location: "locB", label: "typeA locB" },
+          status: {
+            publicationStatus: PublicationState.EXTERNAL_HANDOVER_PENDING,
+            withError: false,
+          },
+        },
+      ],
+      activeUser: {
+        name: "fooUser",
+        documentationOffice: { abbreviation: "fooDocumentationOffice" },
+      },
+    })
+
+    expect(
+      screen.queryByRole("link", { name: "Dokumentationseinheit bearbeiten" }),
+    ).not.toBeInTheDocument()
+    expect(
+      screen.getByRole("link", { name: "Dokumentationseinheit übernehmen" }),
+    ).toBeInTheDocument()
+  })
 })
diff --git a/frontend/test/e2e/caselaw/docunit-creation-from-evaluation.spec.ts b/frontend/test/e2e/caselaw/docunit-creation-from-evaluation.spec.ts
@@ -379,16 +379,6 @@ test.describe(
             ).toBeVisible()
           })
 
-          await test.step("Created documentation unit is not editable for foreign docoffice", async () => {
-            const url = `/caselaw/documentunit/${documentNumber}/categories`
-            await getRequest(url, pageWithBghUser)
-            await expect(
-              pageWithBghUser.getByText(
-                "Diese Dokumentationseinheit existiert nicht oder Sie haben keine Berechtigung.",
-              ),
-            ).toBeVisible()
-          })
-
           await test.step("The new documentation unit is added to the list of references", async () => {
             await expect(page.getByLabel("Listen Eintrag")).toHaveCount(2)
 
@@ -406,7 +396,7 @@ test.describe(
             ).toBeVisible()
           })
 
-          await test.step("The new documentation unit is not visible to creating doc office in search with Fremdanlage status", async () => {
+          await test.step("Created documentation unit is not visible to creating doc office in search with Fremdanlage status", async () => {
             await navigateToSearch(page)
 
             await page.getByLabel("Dokumentnummer Suche").fill(documentNumber)
@@ -417,6 +407,34 @@ test.describe(
             const listEntry = page.getByTestId("listEntry")
             await expect(listEntry).toHaveCount(0)
           })
+
+          await test.step("Created documentation unit is visible with 'Übernehmen' button to foreign doc office in search with Fremdanlage status", async () => {
+            await navigateToSearch(pageWithBghUser)
+
+            await pageWithBghUser
+              .getByLabel("Dokumentnummer Suche")
+              .fill(documentNumber)
+
+            const select = pageWithBghUser.locator(`select[id="status"]`)
+            await select.selectOption("Fremdanlage")
+            await pageWithBghUser
+              .getByLabel("Nach Dokumentationseinheiten suchen")
+              .click()
+            const listEntry = pageWithBghUser.getByTestId("listEntry")
+            await expect(listEntry).toHaveCount(1)
+            await expect(
+              pageWithBghUser.getByLabel("Dokumentationseinheit übernehmen"),
+            ).toBeVisible()
+          })
+          await test.step("Created documentation unit is not editable for foreign docoffice, as long as it has not been taken over", async () => {
+            const url = `/caselaw/documentunit/${documentNumber}/categories`
+            await getRequest(url, pageWithBghUser)
+            await expect(
+              pageWithBghUser.getByText(
+                "Diese Dokumentationseinheit existiert nicht oder Sie haben keine Berechtigung.",
+              ),
+            ).toBeVisible()
+          })
         } finally {
           await deleteDocumentUnit(page, documentNumber)
         }