Cognition column limit (#1338)

* made changes for the coginition colum limit and fixed test cases for the same * made changes for the coginition colum limit and fixed test cases for the same
digiteinfotech · Jul 12, 2024 · f293d60 · f293d60
1 parent 53481e9
commit f293d60
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/kairon/shared/cognition/processor.py b/kairon/shared/cognition/processor.py
@@ -49,7 +49,7 @@ def is_column_collection_limit_exceeded(bot, user, metadata):
         """
         bot_settings = MongoProcessor.get_bot_settings(bot, user)
         bot_settings = bot_settings.to_mongo().to_dict()
-        return len(metadata) >= bot_settings["cognition_columns_per_collection_limit"]
+        return len(metadata) > bot_settings["cognition_columns_per_collection_limit"]
 
     @staticmethod
     def is_same_column_in_metadata(metadata):

diff --git a/tests/integration_test/services_test.py b/tests/integration_test/services_test.py
@@ -2256,7 +2256,8 @@ def test_metadata_upload_api_column_limit_exceeded():
                 {"column_name": "age", "data_type": "int", "enable_search": True, "create_embeddings": False},
                 {"column_name": "color", "data_type": "str", "enable_search": True, "create_embeddings": True},
                 {"column_name": "name", "data_type": "str", "enable_search": True, "create_embeddings": True},
-                {"column_name": "gender", "data_type": "str", "enable_search": True, "create_embeddings": True}
+                {"column_name": "gender", "data_type": "str", "enable_search": True, "create_embeddings": True},
+                {"column_name": "experience", "data_type": "str", "enable_search": True, "create_embeddings": True}
             ],
             "collection_name": "test_metadata_upload_api_column_limit_exceeded"
         },

diff --git a/tests/unit_test/data_processor/data_processor_test.py b/tests/unit_test/data_processor/data_processor_test.py
@@ -14876,7 +14876,8 @@ def test_save_payload_metadata_column_limit_exceeded(self):
                 {"column_name": "age", "data_type": "int", "enable_search": True, "create_embeddings": False},
                 {"column_name": "color", "data_type": "str", "enable_search": True, "create_embeddings": True},
                 {"column_name": "name", "data_type": "str", "enable_search": True, "create_embeddings": True},
-                {"column_name": "gender", "data_type": "str", "enable_search": True, "create_embeddings": True}
+                {"column_name": "gender", "data_type": "str", "enable_search": True, "create_embeddings": True},
+                {"column_name": "experience", "data_type": "str", "enable_search": True, "create_embeddings": True}
             ],
             "collection_name": "test_save_payload_metadata_column_limit_exceeded",
             "bot": bot,