Fallback api fix #1045
Closed
Fallback api fix #1045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udit-pandey
suggested changes
Oct 9, 2023
kairon/history/processor.py
Outdated
| ])) | ||
| action_counts = list(conversations.aggregate([{"$match": {"$and": [ | ||
| {"type": "flattened"}, | ||
| {"data.intent": {"$nin": ['action_listen', 'action_session_start']}}, |
There was a problem hiding this comment.
these are not actions, can be removed
There was a problem hiding this comment.
also, why is this named as action_count? isnt it actually a count of total conversation steps?
kairon/history/processor.py
Outdated
| {"$project": {"_id": 1, "count": 1}} | ||
| ], allowDiskUse=True) | ||
| ) | ||
| new_session = list(conversations.aggregate([ |
| ] | ||
| } | ||
| }}, | ||
| {"$match": {'$or': [{"events.name": fallback_action}, |
There was a problem hiding this comment.
use nlu_fallback action for filtering here
| {"$sort": {"event.timestamp": 1}}, | ||
| {"$group": {"_id": "$sender_id", "events": {"$push": "$event"}}}, | ||
| {"$addFields": {"last_event": {"$last": "$events"}}}, | ||
| {"$match": {'$or': [{"last_event.name": fallback_action}, |
There was a problem hiding this comment.
use nlu_fallback action for filtering here
| conversations.aggregate([ | ||
| {"$match": {"event.timestamp": {"$gte": Utility.get_timestamp_from_date(from_date), | ||
| "$lte": Utility.get_timestamp_from_date(to_date)}, | ||
| "event.name": { |
There was a problem hiding this comment.
use nlu_fallback, action_session_start action for filtering here
| ] | ||
| } | ||
| }}, | ||
| {"$match": {'$or': [{"events.name": fallback_action}, |
| {"$sort": {"event.timestamp": 1}}, | ||
| {"$group": {"_id": "$sender_id", "events": {"$push": "$event"}}}, | ||
| {"$addFields": {"last_event": {"$last": "$events"}}}, | ||
| {"$match": {'$or': [{"last_event.name": fallback_action}, |
kairon/history/processor.py
Outdated
| {"$project": {"_id": 1, "count": 1}} | ||
| ], allowDiskUse=True) | ||
| ) | ||
| new_session = list(conversations.aggregate([ |
|
|
||
| assert hit_fall_back["fallback_count"] == 100 |
There was a problem hiding this comment.
tests should pass without modifying them
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed fallback api issue in analytics page.