Fixed - Collection is getting deleted even after it is attached to prompt action. #1070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nupur-khare
commented
Oct 31, 2023
nupur-khare
commented
- Added unit and integration test cases.
- Fixed test cases.
added 2 commits
October 31, 2023 19:38
…ompt action. 1. Added unit and integration test cases. 2. Fixed test cases.
…ompt action. 1. Added unit and integration test cases. 2. Fixed test cases.
udit-pandey
suggested changes
Nov 1, 2023
| @@ -949,7 +949,7 @@ def check(cls, values): | |||
|
|
|||
| class CognitionSchemaRequest(BaseModel): | |||
| metadata: List[ColumnMetadata] = None | |||
| collection_name: str | |||
| collection_name: constr(to_lower=True, strip_whitespace=True) | |||
There was a problem hiding this comment.
this change must also go for collection field in CognitiveDataRequest
| @@ -1893,14 +2004,15 @@ def _mock_get_bot_settings(*args, **kwargs): | |||
| payload = { | |||
| "data": {"details": "AWS"}, | |||
| "content_type": "json", | |||
| "collection": "Details" | |||
| "collection": "details" | |||
There was a problem hiding this comment.
the code must handle it, why was it changed explicitly?
added 3 commits
November 1, 2023 08:03
…ompt action. 1. Added unit and integration test cases. 2. Fixed test cases.
…ompt action. 1. Added unit and integration test cases. 2. Fixed test cases.
…ompt action. 1. Added unit and integration test cases. 2. Fixed test cases.
udit-pandey
suggested changes
Nov 1, 2023
| @@ -1272,25 +1273,36 @@ def _mock_get_bot_settings(*args, **kwargs): | |||
| assert actual["data"]["_id"] | |||
| assert actual["error_code"] == 0 | |||
|
|
|||
| cognition_schema = CognitionSchema.objects(bot=pytest.bot, id=pytest.schema_id).get() | |||
There was a problem hiding this comment.
why was list schema api called here?
please call rest api
…ompt action. 1. Added unit and integration test cases. 2. Fixed test cases.
* Added changes to log whatsapp webhook response in db. * Added test cases to fix coverage issue. * Added test cases to fix coverage issue. * Added test cases to fix coverage issue. * Added test cases in the chat_service_test. * Added test cases in the chat_service_test. --------- Co-authored-by: Mahesh <[email protected]>
…ompt action. 1. Added unit and integration test cases. 2. Fixed test cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.