GBM Private key fix

[maheshsattala]

GBM private_key issue fixed and added test case related to that.

Summary by CodeRabbit

• Bug Fixes

  • Enhanced the channel configuration process to handle specific conditions for the private_key more effectively.

• Tests

  • Updated unit tests for channel configuration to cover scenarios with invalid private_key.
  • Improved session history test assertions for better validation of chat sessions.

[coderabbitai]

Walkthrough

Walkthrough

The codebase has been updated to enhance channel configuration security and improve testing. A new condition in processor.py adjusts the private_key under specific scenarios, bolstering security measures. In chat_test.py, unit tests have been refined for better validation of channel configurations with an invalid private_key and for more robust testing of session history retrieval.

Changes

File Path	Change Summary
.../chat/processor.py	Added conditional logic to modify private_key in save_channel_config.
.../chat/chat_test.py	Updated tests for invalid private_key handling and session history assertions.

Poem

In the warren of code, the changes are sown,
Secure keys in their burrows, safely at home.
Tests hop through the fields, assertions in play,
A rabbit's work done, hip-hop-hurray! 🎉🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat with CodeRabbit Bot (@coderabbitai)

• You can directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• You can tag CodeRabbit on specific lines of code or entire files in the PR by tagging @coderabbitai in a comment. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• You can tag @coderabbitai in a PR comment and ask questions about the PR and the codebase. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid.
  • @coderabbitai read the files in the src/scheduler package and generate README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[coderabbitai]

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits

Files that changed from the base of the PR and between 3d4e543 and fcf1f2a.

Files selected for processing (2)

• kairon/shared/chat/processor.py (1 hunks)
• tests/unit_test/chat/chat_test.py (1 hunks)

Additional comments: 2

kairon/shared/chat/processor.py (1)

• 26-28: The conditional block correctly replaces "\\n" with "\n" in the private_key. However, it's important to ensure that the private_key is not logged or exposed in any way, which could lead to security issues. Verify that the private_key is handled securely throughout the application.

Verification successful

---

The search for logging statements that might include the private_key within the kairon/shared/chat/ directory only returned the lines from the processor.py file that are part of the PR changes. There are no indications of logging statements that include the private_key in the output provided.

• No logging statements including private_key were found in the kairon/shared/chat/ directory.

Scripts Executed

The following scripts were executed for the analysis:

---

Script:

#!/bin/bash
# Search for logging statements that might include the private_key.
rg --type py "private_key" -- "kairon/shared/chat/"

Length of output: 402

tests/unit_test/chat/chat_test.py (1)

• 470-496: The test test_save_channel_config_business_messages_with_invalid_private_key correctly mocks the endpoint and checks the channel configuration. However, the private key is included in the test code, which could be a security risk if it's a real key. Ensure that any sensitive keys are mocked or obfuscated to prevent security leaks.

[udit-pandey]

approved