Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated system.yml #1633

Merged
merged 1 commit into from
Dec 10, 2024
Merged

updated system.yml #1633

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions system.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,8 @@ events:
pyscript_evaluator: ${PYSCRIPT_TASK_DEFINITION}
scheduler_evaluator: ${SCHEDULER_TASK_DEFINITION}
content_importer: ${DOC_CONTENT_IMPORTER_TASK_DEFINITION}
mail_channel_read: ${MAIL_CHANNEL_READ_TASK_DEFINITION}
mail_channel_process: ${MAIL_CHANNEL_PROCESS_TASK_DEFINITION}
email_channel_read_mails: ${MAIL_CHANNEL_READ_TASK_DEFINITION}
email_channel_process_mails: ${MAIL_CHANNEL_PROCESS_TASK_DEFINITION}
Comment on lines +142 to +143
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codebase verification

Task name changes require updates in multiple files

The search results reveal that while the task names in system.yaml have been updated to use "email_", there are several files that still use the old "mail_" prefix in their code:

  • kairon/shared/constants.py: Class attributes still use mail_channel_ prefix
  • kairon/events/definitions/factory.py: Event mappings use old naming
  • kairon/events/definitions/mail_channel.py: Event references need updating
  • kairon/__init__.py: Module and variable names use old prefix
  • kairon/events/utility.py: Event class references need updating
  • Various test files still use the old naming convention

The changes should be consistent across the entire codebase to maintain naming conventions and prevent potential issues.

🔗 Analysis chain

LGTM! Verify the task name changes across the codebase.

The renaming from "mail" to "email" improves clarity and consistency. However, we should verify that these task names aren't referenced elsewhere in the codebase.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Description: Search for any references to the old task names that might need updating

echo "Searching for old task name references..."
rg -i "mail_channel_read|mail_channel_process" --type yaml --type python

echo "Searching for new task name references to ensure correct usage..."
rg -i "email_channel_read_mails|email_channel_process_mails" --type yaml --type python

Length of output: 459

Script:

#!/bin/bash
# Let's try without specifying file types and use different patterns
echo "Searching for old task name references..."
rg -i "mail_channel_read|mail_channel_process"

echo "Searching for new task name references..."
rg -i "email_channel_read_mails|email_channel_process_mails"

# Also search for the environment variable names
echo "Searching for environment variable references..."
rg "MAIL_CHANNEL_.*TASK_DEFINITION"

Length of output: 4868

scheduler:
collection: ${EVENT_SCHEDULER_COLLECTION:"kscheduler"}
type: ${EVENT_SCHEDULER_TYPE:"kscheduler"}
Expand Down
Loading