Fixed floating point data type check in knowledge vault

[himanshugt16]

Summary by CodeRabbit

• New Features

  • Improved error handling for float validation in data processing, allowing integer values in float fields.

• Bug Fixes

  • Enhanced validation logic for float inputs to provide clearer feedback on invalid data types.

• Tests

  • Added a new test case for validating integer input in float fields.
  • Updated comments in existing tests for clarity.

[coderabbitai]

Walkthrough

The changes in this pull request focus on the CognitionDataProcessor class within kairon/shared/cognition/processor.py, specifically enhancing the validate_column_values method. The method now attempts to convert values to floats instead of raising an exception immediately for non-float inputs. Additionally, the test suite in tests/unit_test/data_processor/data_processor2_test.py is updated to include a new test case for validating integer inputs in float fields and minor adjustments to existing tests.

Changes

File Path	Change Summary
kairon/shared/cognition/processor.py	Modified validate_column_values method to attempt float conversion and improve error handling.
tests/unit_test/data_processor/data_processor2_test.py	Added new test test_validate_metadata_and_payload_int_value_in_float_field and updated comments in existing tests.

Possibly related PRs

• Updated code to save data in cognition data in respective data types #1618: This PR also modifies the validate_column_values method in the CognitionDataProcessor class, enhancing the validation logic for data types, which is directly related to the changes made in the main PR regarding float validation.

Suggested reviewers

• sfahad1414

Poem

In the land of code where rabbits play,
Float values now have a brighter day.
With tests that check both float and int,
Our data's safe, no need for a hint!
Hops of joy for the changes made,
In the garden of logic, we’re never afraid! 🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)

kairon/shared/cognition/processor.py (1)

393-399: Improve error handling in float validation.

The float validation logic is good, but the error handling can be improved by preserving the original exception context.

Consider this improvement:

 if data_type == CognitionMetadataType.float.value:
     try:
-        return float(value)
+        float(value)  # validate type
     except (ValueError, TypeError) as err:
         raise AppException(
             f"Invalid data type for '{column_name}': Expected float value"
-        )
+        ) from err

🧰 Tools

🪛 Ruff (0.8.0)

397-399: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between cbcccc2 and 2a6ae4a.

📒 Files selected for processing (2)

• kairon/shared/cognition/processor.py (1 hunks)
• tests/unit_test/data_processor/data_processor2_test.py (1 hunks)

🧰 Additional context used

🪛 Ruff (0.8.0)

kairon/shared/cognition/processor.py

397-399: Within an except clause, raise exceptions with raise ... from err or raise ... from None to distinguish them from errors in exception handling

(B904)

🔇 Additional comments (2)

tests/unit_test/data_processor/data_processor2_test.py (2)

117-117: LGTM!

The test data update maintains consistency with the test's purpose.

---

124-138: LGTM! Well-structured test case.

The new test case effectively validates that integer values are accepted in float fields, following the existing test patterns and maintaining good test coverage.

[hiteshghuge]

reviewed