entity extrctor fixed

[sfahad1414]

Summary by CodeRabbit

• New Features
  • Introduced a method to enhance entity processing by appending extractor names to entities.

[coderabbitai]

Walkthrough

The pull request introduces a new method add_extractor_name to the LLMClassifier class in the LLM classifier module. This method enhances entity processing by adding the extractor's name to each entity in a given list of entities. The method checks if each entity is a dictionary and, if so, appends an extractor name as a new key-value pair, providing additional metadata about the source of each extracted entity. The overall control flow of the class remains unchanged.

Changes

File	Change Summary
kairon/nlu/classifiers/llm.py	Added add_extractor_name method to LLMClassifier class to annotate entities with extractor information

Poem

🐰 A rabbit's tale of code so bright,
Entities tagged with extractor might!
Each dictionary now bears a name,
Revealing the source of its claim.
Metadata dancing with glee,
In the world of NLU, we're free! 🔍

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4836c24 and ff57476.

📒 Files selected for processing (1)

• kairon/nlu/classifiers/llm.py (2 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• kairon/nlu/classifiers/llm.py

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

kairon/nlu/classifiers/llm.py (1)

298-302: Avoid in-place mutation before copying the entity dictionary.

You are modifying entity by adding the extractor name before copying it. This can inadvertently mutate the original dictionary reference. For safer code, copy first, then modify:

for entity in entities:
    if isinstance(entity, dict):
-       entity[EXTRACTOR] = self.name
-       entities_new.append(entity.copy())
+       entity_copy = entity.copy()
+       entity_copy[EXTRACTOR] = self.name
+       entities_new.append(entity_copy)

🧰 Tools

🪛 Ruff (0.8.2)

300-300: Undefined name EXTRACTOR

(F821)

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6dc88e8 and 4836c24.

📒 Files selected for processing (1)

• kairon/nlu/classifiers/llm.py (1 hunks)

🧰 Additional context used

🪛 Ruff (0.8.2)

kairon/nlu/classifiers/llm.py

300-300: Undefined name EXTRACTOR

(F821)

🔇 Additional comments (1)

kairon/nlu/classifiers/llm.py (1)

285-302: Double-check the self.name attribute.

The method sets entity[EXTRACTOR] = self.name. Ensure that self.name is defined (often inherited from GraphComponent or EntityExtractorMixin). Otherwise, the attribute might be missing or undefined, leading to potential runtime errors.

🧰 Tools

🪛 Ruff (0.8.2)

300-300: Undefined name EXTRACTOR

(F821)

[coderabbitai]

⚠️ Potential issue

Import or define the EXTRACTOR constant.

According to the static analysis hint (F821), EXTRACTOR is undefined. To fix this, add an appropriate definition or import. For example:

+ from rasa.shared.nlu.constants import EXTRACTOR

Committable suggestion skipped: line range outside the PR's diff.

🧰 Tools

🪛 Ruff (0.8.2)

300-300: Undefined name EXTRACTOR

(F821)

[sushantpatade]

Approved