Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixing removal of attributes from graphs - #23 #26

Merged
merged 3 commits into from
May 20, 2024
Merged

fixing removal of attributes from graphs - #23 #26

merged 3 commits into from
May 20, 2024

Conversation

mpan322
Copy link
Contributor

@mpan322 mpan322 commented May 19, 2024

  • fixing error in node removal code
  • added support for removal by both key and value from graph attributes
  • fixing comment

Issue: #23

  • fixed removal of attributes from graph / graph like graphviz objects.
  • added support for removal by key (ex. "label") and by entire value (ex. "label=test").
  • updated some tests.

@mpan322
Copy link
Contributor Author

mpan322 commented May 19, 2024

I wasn't able to find a regex package for gap - if one exists please let me know as it would allow some of the code to be deleted / simplified.

@james-d-mitchell
Copy link
Member

There's no regret package for gap that I'm aware of unfortunately. Thanks for the PR!

@james-d-mitchell james-d-mitchell merged commit b0d67a1 into digraphs:main May 20, 2024
6 checks passed
@james-d-mitchell
Copy link
Member

No regex lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpan322 @james-d-mitchell