Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't sort since nova did it before #85

Merged
merged 1 commit into from
Mar 26, 2021

Conversation

GautierDele
Copy link
Contributor

Hello @dillingham,

To follow #24, sorting by display isn't necessary since the user already provided the sort in nova

Gautier

Hello there,

To follow dillingham#24, sorting by display isn't necessary since the user already provided the sort in nova

Gautier
@GautierDele
Copy link
Contributor Author

@dillingham, did you have any time to have a look on that ?

Thanks 😄

@dillingham dillingham merged commit 3a34356 into dillingham:master Mar 26, 2021
@GautierDele GautierDele deleted the patch-1 branch March 26, 2021 13:20
@dillingham dillingham mentioned this pull request Apr 20, 2021
@YasamDevelopment
Copy link

Hi @GautierDele,

What do you mean by "since the user already provided the sort in nova"? How can the user provide a sort in Nova?

I would like to sort the items listed in my nova-attach-many field. From my understanding, it's up to the field itself to do the sorting, since Nova will just give the list ordered by ID (or whatever the key is). I just wrote a Pull Request (#89), that allows user to specify 'orderBy' info to this nova-attach-many field. But based on your comment, it sounds almost as if you can do this in Nova.... So I think maybe I am missing something. Can you please tell me how you can specify a sort in Nova for this nova-attach-many field?

Thanks!

@GautierDele
Copy link
Contributor Author

Hello,

You can specify an order by in the index query in nova which is used in our case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants