-
-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for binary file read #458
Open
miniBill
wants to merge
4
commits into
dillonkearns:master
Choose a base branch
from
miniBill:binary-read
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👷 Deploy request for elm-pages-todos pending review.Visit the deploys page to approve it
|
supermario
reviewed
Mar 23, 2024
miniBill
changed the title
[WIP] add suport for binary file read
Add suport for binary file read
Mar 23, 2024
miniBill
changed the title
Add suport for binary file read
Add support for binary file read
Mar 30, 2024
Rebased |
@dillonkearns how do you feel about this PR? Does it look like it could be merged or would you prefer to have a discussion around APIs, base64 and efficiency? |
miniBill
force-pushed
the
binary-read
branch
from
September 24, 2024 05:40
6a54862
to
40a6867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.