Fix UnboundLocalError when accessing amount #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calellowitz
reviewed
Jan 27, 2025
| except ValueError: | ||
| invalid_rows.append((row, "amount must be an integer")) | ||
| payments[username] = amount |
There was a problem hiding this comment.
I think the "correct" way to do this is put it in an else clause. We don't want to catch errors with that statement (although I am not sure that is possible here), but only want it to run if the the try succeeds, and else is the standard way to do that.
There was a problem hiding this comment.
Thanks. Added. 14828cf
calellowitz
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Product Description
This fixes an error when the user tries to submit payments with non-integer amounts i.e INR 1000, USD 100.
Technical Summary
This error was due to the Unbound amount variable when the ValueError exception occurred for non-integer amounts.
Sentry Link
Labels & Review