Merge pull request #35057 from dimagi/jc/fix-unsaved-favorites-reports

Fix saved report for data forwarding records being deleted

corehq/apps/saved_reports/models.py

@@ -48,6 +48,7 @@
 )
 from corehq.apps.reports.dispatcher import (
     CustomProjectReportDispatcher,
+    DomainReportDispatcher,
     ProjectReportDispatcher,
     ReleaseManagementReportDispatcher,
 )
@@ -203,7 +204,8 @@ def _dispatcher(self):
             CustomProjectReportDispatcher,
             EnterpriseReportDispatcher,
             ReleaseManagementReportDispatcher,
-            CaseManagementMapDispatcher
+            CaseManagementMapDispatcher,
+            DomainReportDispatcher,
         ]
 
         for dispatcher in dispatchers:

corehq/apps/saved_reports/tests/test_models.py

@@ -81,6 +81,15 @@ def test_report_config_does_not_have_datespan_if_not_in_params(self):
         self.assertEqual(self.config.filters.get('startdate'), None)
         self.assertEqual(self.config.filters.get('enddate'), None)
 
+    def test_report_config_for_type_domain_report_is_not_deleted_when_access_dispatcher(self):
+        # The dispatcher property surprisingly deletes the report config when the report type
+        # doesn't match any of the list of dispatcher's prefix
+        config = ReportConfig(report_type='domain_report')
+        config.save()
+        self.addCleanup(config.delete)
+        config._dispatcher
+        self.assertEqual(config.doc_type, 'ReportConfig')
+
 
 class TestReportNotification(TestCase):
     def test_unauthorized_user_cannot_view_report(self):