Upgrade to architect 0.6.0 #31247
Merged
Upgrade to architect 0.6.0 #31247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
added
product/invisible
dannyroberts
approved these changes
Mar 14, 2022
biyeun
approved these changes
Mar 21, 2022
dannyroberts
approved these changes
Mar 21, 2022
|
QA passed with this and Django 3.2 on staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required for upgrade to Django 3.2
Safety Assurance
Safety story
I don't know how well our tests cover usage of architect. It is used by auditcare, project_access, hqwebapp, sync logs, device reports, and project_limits for 2fa logging. The architect project does test against Django 2.2, 3.0, and 3.1, but notably not Django 3.2. A PR was submitted to test on Python 3.9 and Django 3.2.
I reviewed the change log from 0.5.6 to 0.6.0, and it appears not much has changed other than adding compatibility for Django 3.x and removing support for older versions of various libraries.
Automated test coverage
No new tests added.
QA Plan
Probably will QA as part of the Django 3.2 upgrade.
Rollback instructions
Labels & Review