Fix bug with emailing custom enterprise report date range #35204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
millerdev
approved these changes
Oct 10, 2024
|
What test would you want to see here? The test that comes to mind is just verifying that the parameters get passed to the celery task? Or are you thinking of an end-to-end test where I verify the output? I do want to get this merged, but I'm not opposed to writing a test to verify this behavior if there's a good one to write |
|
I wasn't thinking of an end-to-end test. Verifying that the correct kwargs are passed to celery seems adequate. |
|
Sure, I will handle that in a follow up PR, thanks! |
3 tasks
Follow-up PR: #35205 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technical Summary
Bug was included in #35166, where any customized data range was ignored for actually generating the CSV download. This fix passes the custom date parameters on to the download generation task.
Feature Flag
Safety Assurance
Safety story
Verified the fix locally and on staging.
Automated test coverage
No tests.
QA Plan
No QA
Rollback instructions
Labels & Review