Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small bug fix for Enterprise CommCare Version Compliance #35528

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

jingcheng16
Copy link
Contributor

@jingcheng16 jingcheng16 commented Dec 17, 2024

strptime() argument 1 must be str, not None

Technical Summary

Related sentry error

Feature Flag

No

Safety Assurance

Safety story

Fixed a bug caught by sentry

Automated test coverage

QA Plan

No

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

Copy link

sentry-io bot commented Dec 17, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: corehq/apps/reports/util.py

Function Unhandled Issue
get_commcare_version_and_date_from_last_usage UnboundLocalError: local variable 'version' referenced before assignment /a/{domain}/enterprise...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@jingcheng16 jingcheng16 marked this pull request as ready for review December 17, 2024 16:01
@jingcheng16 jingcheng16 added the product/all-users-all-environments Change impacts all users on all environments label Dec 17, 2024
strptime() argument 1 must be str, not None
@jingcheng16 jingcheng16 force-pushed the jc/fix-bug-in-commcare-version-compliance-tile branch from 228fead to 3e1f3f9 Compare December 17, 2024 16:05
@jingcheng16 jingcheng16 merged commit 95a1188 into master Dec 17, 2024
13 checks passed
@jingcheng16 jingcheng16 deleted the jc/fix-bug-in-commcare-version-compliance-tile branch December 17, 2024 16:24
Copy link

sentry-io bot commented Dec 17, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: strptime() argument 1 must be str, not None /a/{domain}/enterprise/dashboard/{slug}/total/ View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
product/all-users-all-environments Change impacts all users on all environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants