Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use QuillJS as rich text editor #35695

Draft
wants to merge 14 commits into
base: master
Choose a base branch
from
Draft

Use QuillJS as rich text editor #35695

wants to merge 14 commits into from

Conversation

MartinRiese
Copy link
Contributor

Product Description

Use QuillJs for rich text editing since its license works out well for us.

image

Technical Summary

Feature Flag

rich_text_emails

Safety Assurance

Safety story

Automated test coverage

QA Plan

Rollback instructions

  • This PR can be reverted after deploy with no further considerations

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the dependencies Pull requests that update a dependency file label Jan 28, 2025
@MartinRiese MartinRiese changed the title Riese/quill Use QuillJS as rich text editor Jan 28, 2025
@MartinRiese MartinRiese force-pushed the riese/quill branch 3 times, most recently from 497069a to 5b66b0c Compare January 30, 2025 17:50
@kaapstorm kaapstorm mentioned this pull request Jan 31, 2025
Merged
4 tasks
@MartinRiese
Use quill for rich editor
1177506
@MartinRiese
Additional formatting options
f1cf6ee
@MartinRiese
Custom font set for quill
83ca7db 
* And some cosmetic changes
* Still need to figure out where to put the styles
@MartinRiese
Add image upload functionality to quill
d94063b 
* Move toolbar into template to make it customizable
@dimagimon dimagimon added the Risk: Medium Change affects files that have been flagged as medium risk. label Feb 5, 2025
@MartinRiese
Use global _quill.sccs
ddeffd0 
* Started working for some reason now.
@MartinRiese
Round quill editor corners to match style of forms
33292db
@MartinRiese
Add missing fonts
552c115
@MartinRiese
Revert "Use global _quill.sccs"
1afde94 
This reverts commit ddeffd0.
@MartinRiese
Add font to font drop down items
98f30d0 
* sadly adding it to the content function did not work so I had to list
  them out
* also add rounded corners
@MartinRiese
Fix lint issues
720cc1e
@MartinRiese
Use quill handler instead of listening directly
e92c7ff 
* Using the ql-image class overrode the eventlistener
* Using the handler is cleaner and allow us to extract the
  handler function
@MartinRiese
Just use css file
e130c22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orangejenny orangejenny Awaiting requested review from orangejenny orangejenny will be requested when the pull request is marked ready for review orangejenny is a code owner

@biyeun biyeun Awaiting requested review from biyeun biyeun will be requested when the pull request is marked ready for review biyeun is a code owner

@mkangia mkangia Awaiting requested review from mkangia mkangia will be requested when the pull request is marked ready for review mkangia is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file Risk: Medium Change affects files that have been flagged as medium risk.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MartinRiese @dimagimon