Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete ewsghana app #35745

Merged
merged 3 commits into from
Feb 10, 2025
Merged

Delete ewsghana app #35745

merged 3 commits into from
Feb 10, 2025

Conversation

jingcheng16
Copy link
Contributor

@jingcheng16 jingcheng16 commented Feb 6, 2025

Technical Summary

Ticket: https://dimagi.atlassian.net/browse/SAAS-16525

I came across this app and noticed it is no longer used so want to remove it.

Jenny also confirmed this is for a project that is over.

ewsghana was a project that had a lot of custom code. It's over now, and most of the related code has been deleted (see PRs like this and this).

I searched the remaining 3 models in the code, no reference.

Checked number of data on production, I think this is an amount that can be handled in deploy.

In [1]: from custom.ewsghana.models import *

In [2]: FacilityInCharge.objects.count()
Out[2]: 609

In [3]: EWSExtension.objects.count()
Out[3]: 1011

In [4]: SQLNotification.objects.count()
Out[4]: 56443

Safety Assurance

Safety story

I searched the remaining 3 models in the code, no reference. Also checked all the entities that have reference to these 3 models, mainly some constraint and index.

Automated test coverage

QA Plan

Migrations

  • The migrations in this code can be safely applied first independently of the code

Rollback instructions

  • This PR can be reverted after deploy with no further considerations
    I didn't write any revert code, since I believe we won't do reversion. Also, even if reversion, all the data is already permanently deleted.

Labels & Review

  • Risk label is set correctly
  • The set of people pinged as reviewers is appropriate for the level of risk of the change

@dimagimon dimagimon added the reindex/migration Reindex or migration will be required during or before deploy label Feb 6, 2025
@jingcheng16 jingcheng16 marked this pull request as ready for review February 6, 2025 22:23
@@ -23,7 +23,7 @@ hqDefine("reports/js/bootstrap5/standard_hq_report", [
}

if (typeof standardHQReport !== 'undefined') {
// Custom reports, notably ewsghana
// Custom reports
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed for anything other than ewsghana? If not, maybe it can be removed too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed for custom reports. Jenny will have a PR to consolidate this file, then standard reports, custom reports, UCR will use the same code.

@jingcheng16
Copy link
Contributor Author

Offlined with Danny and did some check together, Danny signed off on deleting it, so I'll merge the PR.

@jingcheng16 jingcheng16 merged commit bba4cff into master Feb 10, 2025
12 of 14 checks passed
@jingcheng16 jingcheng16 deleted the jc/delete-ewsghana branch February 10, 2025 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
reindex/migration Reindex or migration will be required during or before deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants