Assistant Archival Cleanup

[stephherbers]

Description

990
Followup logic changes for assistant versioning archiving.

Screen.Recording.2025-01-20.at.3.14.50.PM.mov

Now, when a assistant is archived that is a working version, all its versions is also archived and deleted from open AI.

Also from a UI standpoint. When it checks whether is can be archived, if its the working version it checks for all dependencies for all the versions not just the working version and displays everything that needs to be archived first. This way, the version won't be archived with the open AI deleted with something (exp or pipeline) still referencing it). Only the working and published references will be displayed as blocking to the user for the assistant to be archived

User Impact

Demo

loom demo

When a user goes to archive an assistant, there will be 3 uses cases checked:

1. Are there any published or working experiments that are referencing the assistant?
2. Are there and working pipelines are thar referencing the assistant
3. Are there and published experiments that have pipelines that are referencing the assistant.
   For cases 1 & 3, it links to the experiment version that is blocking, and for case 2 it links to the pipeline that is blocking

Docs

being updated now

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 94.48276% with 8 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
apps/assistants/views.py	20.00%	4 Missing ⚠️
apps/experiments/models.py	25.00%	3 Missing ⚠️
apps/assistants/models.py	95.65%	1 Missing ⚠️

Additional details and impacted files

📢 Thoughts on this report? Let us know!

[snopoke]

After reviewing this and testing it locally I think we need to take a step back and look more holistically at how we trace references to objects and make that visible in the UI.

I've started a doc to make it easier to collaborate on the thoughts and ideas: https://docs.google.com/document/d/1Z09GNpO17izoVcRPGSmppNthFruyRJ0033T-RYvapoE/edit?tab=t.0

[stephherbers]

noting that we are moving forward with changes from the doc so those commits will be coming in later and I will re-requests reviews

[SmittieC]

It's coming together nicely. Just two small comments

[snopoke]

This is very close now. I'm going to check it out and test it locally.

[stephherbers]

@snopoke @SmittieC updated the screenshot in the description-- and I'll try for rearrqanging the confirmation modals a bit more before calling it quits. I believe this covers everything we discussed, plus updated tests

[snopoke]

so close!

[snopoke]

Looks ready to merge once tests are passing:

=========================== short test summary info ============================
FAILED apps/assistants/tests/test_delete.py::TestAssistantArchival::test_archive_assistant_fails_with_working_related_versioned_pipeline_and_working_experiment - assert not True
 +  where True = <bound method OpenAiAssistant.archive of <OpenAiAssistant: >>()
 +    where <bound method OpenAiAssistant.archive of <OpenAiAssistant: >> = <OpenAiAssistant: >.archive
FAILED apps/assistants/tests/test_delete.py::TestAssistantArchival::test_archive_assistant_fails_with_working_related_pipeline - assert not True
 +  where True = <bound method OpenAiAssistant.archive of <OpenAiAssistant: >>()
 +    where <bound method OpenAiAssistant.archive of <OpenAiAssistant: >> = <OpenAiAssistant: >.archive
=========== 2 failed, 878 passed, 448 warnings in 323.87s (0:05:23) ============