Fix: Populate the node assistant's trace service with the existing callback #1091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #1088
Description
The issue was that the
trace_service
gets initialized here, but only callback is being passed in as config to the runnable. When we initialize theAssistantAdapter
for the pipeline (see here), we fetch a fresh instance of the tracing service, but uninitialized.The idea behind the PR is to essentially initialize the tracing service with the existing callback that already has a trace that we can piggyback on.
We don't have to do this for the
LLMResponseWithPrompt
node, because it's not trying to update the trace with extra metadata as the assistant node is doing.User Impact
Users would be able to use langfuse tracing services with pipeline assistants.
Demo
N/A
Docs
N/A