Display which Assistants will be deleted with team deletion #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the user to warn them
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. Additional details and impacted files📢 Thoughts on this report? Let us know! |
SmittieC
reviewed
Feb 7, 2025
| @@ -17,6 +19,12 @@ | |||
| from apps.web.forms import set_form_fields_disabled | |||
|
|
|||
|
|
|||
| def get_related_assistants(team): | |||
| related_assistants = OpenAiAssistant.objects.filter(team=team) | |||
| print(related_assistants) | |||
SmittieC
reviewed
Feb 7, 2025
| @@ -9,6 +9,14 @@ <h3 class="font-bold text-lg">{% translate "Really delete team?" %}</h3> | |||
| <strong>This action cannot be undone.</strong> | |||
| {% endblocktranslate %} | |||
| </p> | |||
| {% if related_assistants %} | |||
| <h4 class="font-semibold my-2">These OpenAI Assistants will also be deleted:</h4> | |||
There was a problem hiding this comment.
Wondering if we should tell users that we'll remove the assistants from OpenAI as well?
There was a problem hiding this comment.
+1 - explicit is better and this could be interpreted as we'll delete them from OCS only
Suggested change
| <h4 class="font-semibold my-2">These OpenAI Assistants will also be deleted:</h4> | |
| <h4 class="font-semibold my-2">These OpenAI Assistants will also be deleted from OpenAI along with the related files and vector stores:</h4> |
snopoke
previously approved these changes
Feb 7, 2025
snopoke
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of this ticket #1097
Description
(Just a warning not blocking like for archiving) This informing the the assistants will be deleted and which ones for the user and links to them if they so desire to look at them, or they can ignore them completely and still delete the team
User Impact
users are more informed when delete teams
Demo
Docs and Changelog