Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numerical issue on SVD with near-identity matrix #1369

Merged
merged 4 commits into from
Mar 28, 2024
Merged

Fix numerical issue on SVD with near-identity matrix #1369

merged 4 commits into from
Mar 28, 2024

Commits on Mar 28, 2024

  1. fix: Normalize the column once more 

    The column may not be normalized if the `factor` is on a scale of 1e-40.
Possibly, f32 just runs out of precision.

There is likely a better solution to the problem.
    @Vollkornaffe @sebcrozet
    Vollkornaffe authored and sebcrozet committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8f800d9 View commit details
    Browse the repository at this point in the history

  2. chore: Add test that fails before fix

    @Vollkornaffe @sebcrozet
    Vollkornaffe authored and sebcrozet committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    c160299 View commit details
    Browse the repository at this point in the history

  3. chore: add comment providing details on the householder fix.

    @sebcrozet
    sebcrozet committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    4dad6b3 View commit details
    Browse the repository at this point in the history

  4. chore: rename regression test

    @sebcrozet
    sebcrozet committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    5e70d04 View commit details
    Browse the repository at this point in the history