Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GLTF to Convex Hull Collision and Trimesh Examples #285

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

Capta1nCool
Copy link
Contributor

GLTF to Convex Hull Collision:

  • Demonstrates how to convert a GLTF model to a convex hull and handle collisions with other objects.

GLTF to Trimesh Collision:
Illustrates how to use a GLTF model as a trimesh for precise collision detection.

image
image

@Vrixyz Vrixyz added documentation Improvements or additions to documentation dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jul 11, 2024
@Vrixyz
Copy link
Contributor

Vrixyz commented Jul 11, 2024

Thanks for the PR ! It's a great example.

I'm not sure if we want to rely too much on an external library.

three.js is already used for rendering, so I'd say you picked the least controversial one 👍, but this PR may be shifting the realm of rapier.js to support three.js interoperability, so I think we should consider it carefully.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a license accompanying this file ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, A friend of mine made it so we don't need a license. Basically CC0 license especially for me :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the precision!

Unfortunately licensing is quite complex and not risk free, so I'd like to move from this model to either stanford bunny or blender suzanne ; let me know if you're up to make the modification, otherwise I can take it from there.

@Capta1nCool
Copy link
Contributor Author

@Vrixyz Fixed the prettier issue, can you look into it now? Thanks.

@Capta1nCool
Copy link
Contributor Author

should work now @Vrixyz

@Vrixyz
Copy link
Contributor

Vrixyz commented Jul 15, 2024

After consideration, the general direction of using threejs GLTF loader is accepted 🎉 ; so the only blocker now is the model.

Also, I'll want to add a changelog line + test locally the PR before merging :)

@Vrixyz
Copy link
Contributor

Vrixyz commented Jul 23, 2024

I went ahead and changed the model to something less controversial, thanks!

@Vrixyz Vrixyz merged commit 262c307 into dimforge:master Jul 23, 2024
4 checks passed
@Capta1nCool
Copy link
Contributor Author

Hey @Vrixyz ,

Thanks for merging the pull request! I was hoping we could include the sword model in the example, but I trust your judgment. Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation javascript Pull requests that update Javascript code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants