-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GLTF to Convex Hull Collision and Trimesh Examples #285
Conversation
Thanks for the PR ! It's a great example. I'm not sure if we want to rely too much on an external library.
|
testbed3d/static/sword.glb
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a license accompanying this file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, A friend of mine made it so we don't need a license. Basically CC0 license especially for me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the precision!
Unfortunately licensing is quite complex and not risk free, so I'd like to move from this model to either stanford bunny or blender suzanne ; let me know if you're up to make the modification, otherwise I can take it from there.
@Vrixyz Fixed the prettier issue, can you look into it now? Thanks. |
should work now @Vrixyz |
After consideration, the general direction of using threejs GLTF loader is accepted 🎉 ; so the only blocker now is the model. Also, I'll want to add a changelog line + test locally the PR before merging :) |
I went ahead and changed the model to something less controversial, thanks! |
Hey @Vrixyz , Thanks for merging the pull request! I was hoping we could include the sword model in the example, but I trust your judgment. Thanks again! |
GLTF to Convex Hull Collision:
GLTF to Trimesh Collision:
Illustrates how to use a GLTF model as a trimesh for precise collision detection.