Add portable_simd support #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farnoy
commented
Jun 16, 2023
|
|
||
| #[inline(always)] | ||
| unsafe fn extract_unchecked(&self, i: usize) -> Self::Element { | ||
| self.0[i] |
There was a problem hiding this comment.
There's no unchecked version from what I've seen
|
|
||
| #[inline(always)] | ||
| unsafe fn replace_unchecked(&mut self, i: usize, val: Self::Element) { | ||
| self.0[i] = val; |
| }; | ||
| use approx::AbsDiffEq; | ||
| #[cfg(feature = "decimal")] | ||
| use decimal::d128; |
There was a problem hiding this comment.
Have not tested with this feature, TODO
farnoy
commented
Jun 16, 2023
| #[inline(always)] | ||
| fn sample<R: rand::Rng + ?Sized>(&self, rng: &mut R) -> $wrapped { | ||
| <$wrapped>::new($( | ||
| ignore_snd!([self.sample(rng)], [$i]) |
There was a problem hiding this comment.
There's a nicer specialization for packed_simd vectors in the rand crate, not sure if it's faster or by how much. It uses fill_bytes loaded into an int vector and then shuffled to fit into a float vector.
sebcrozet
force-pushed
the
add-portable-simd-support
branch
from
97a1d1e
to
98c6e94
Compare
|
Thank you for this PR! Since it’s been a while, I took the liberty of rebasing on top of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #33
Does not have acceleration for trigonometric functions due to rust-lang/portable-simd#6
Follows the
packed_simdimplementation closely, but masks are calledmask<$elt>x<$lanes>notm<$elt>x<$lanes>Has a few more things than packed_simd like native
recip,floor,ceil,trunc, but crucially it's missing trigonometry accelration.