Base64 encode the scope value #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the feedback. I'll try to take care of these sometime this week. |
This commit adds a test that exercises the issue described in dimo414#50.
bkt permits setting a cache scope (provided via the `BKT_SCOPE` environment variable or the `--scope` command line option) to prevent collisions between unrelated command invocations. Previously, the scope value was used verbatim in a directory path, causing errors if the scope contained path-sensitive characters such as `/`. This commit modifies bkt to base64 encode the scope value. Given a scope value like `https://example.com/`, that means we now end up with a path like: /tmp/bkt-0.7-cache/keys/aHR0cHM6Ly9leGFtcGxlLmNvbS8.C3823B193F1E0C78 Instead of the invalid: /tmp/bkt-0.7-cache/keys/https://www.example.com/.C3823B193F1E0C78 Fixes dimo414#50
|
@dimo414 just following up to see if this needs any more work. Thanks! |
|
Sorry I had missed that you'd updated the PR (you can click the "re-request review" button to notify the reviewer - GitHub's review flow is pretty confusing 😕). Will take a look as soon as I can. |
dimo414
reviewed
Jan 12, 2024
|
Thanks again! Will plan to cut a new release with this soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bkt permits setting a cache scope (provided via the
BKT_SCOPEenvironment variable or the
--scopecommand line option) to preventcollisions between unrelated command invocations. Previously, the scope
value was used verbatim in a directory path, causing errors if the scope
contained path-sensitive characters such as
/.This commit modifies bkt to base64 encode the scope value. Given a scope
value like
https://example.com/, that means we now end up with a pathlike:
Instead of the invalid:
Fixes #50