Prevent setting alt=String("undefined") when the original IMG has no alt #1049
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #871, when using the Image type and the
<img>
has noalt
attribute, Magnific Popup's image.js on line 193 will erroneously replace the image with a newimg
wherealt=String("undefined")
.Problem line in Magnific Popup code (image.js:193):
img.alt = item.el.find('img').attr('alt');
Problem description:
As of jQuery version 1.6 (and Magnific Popup requires > 1.6)
jQuery.attr()
returnsundefined
if the attribute does not exist. When settingimg.alt = undefined
, undefined is converted to a String and the actual text "undefined" gets assigned.Proof of Underlying Problem (in jQuery):
Solution/Fix:
Test
item.el.find('img').attr('alt')
before assigningimg.alt
, as done in this PR.