Homepage Refresh #173
Homepage Refresh #173
Conversation
✅ Deploy Preview for directus-website ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| block_masonry_grid: resolveComponent('BlockMasonryGrid'), | ||
| block_masonry_grid_card: resolveComponent('BlockMasonryGridCard'), | ||
| block_wall_of_love: resolveComponent('BlockWallOfLove'), | ||
| testimonials: resolveComponent('BlockTestimonials'), |
There was a problem hiding this comment.
Is there a specific reason this isn't prefixed with block_
There was a problem hiding this comment.
@bryantgillespie I left it out because whoever made the testimonials in Directus just called it 'Testimonials' no block in the name. Is it possible at all to rename it on that end so it's consistent with the others on the database level?
|
|
||
| const props = defineProps<WithClassAsProps>(); | ||
|
|
||
| const { orientation } = useCarousel(); |
There was a problem hiding this comment.
unused deconstructed var here, which I think means you can remove the import entirely
| </template> | ||
|
|
||
| <style scoped lang="scss"> | ||
| .block-logocloud-ticker { |
There was a problem hiding this comment.
🚨 PEDANTRY ALERT 🚨
BlockLogoCloudLogo implies Logo Cloud is two seperate words, which would mean the class should probably be block-logo-cloud-ticker
If we want to change it then FYI it's present in these files:
| | 'block_carousel_cards' | ||
| | 'block_masonry_grid' | ||
| | 'block_masonry_grid_card' | ||
| | 'testimonials' |
| block_masonry_grid: BlockMasonryGrid[]; | ||
| block_masonry_grid_card: BlockMasonryGridCard[]; | ||
| block_wall_of_love: BlockWallOfLove[]; | ||
| testimonials: BlockTestimonials[]; |
Adding a new glow-up to the Directus homepage.
New Components
Updates to Old Components