Otimize assertIsNotOnBaseObject for performance #37
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertIsNotOnBaseObject currently depends on throwing exception for its base case, that is, when the method is not one of Object's methods.
That is very bad for performance because exceptions are slow in Java when they need to fill the stack trace.
The image shows a flame graph from a application running DRW.
A lot of time is spent on NoSuchMethodException initialization.
I have done a micro benchmark of current implementation versus this proposed implementation:
The results above are for the case when the method is not one of Object's methods.
The results above are for the case when the method is one of Object's methods.
GetMethodBenchmark.zip