Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(events): Validate listeners #280

Merged
merged 2 commits into from
Mar 22, 2024
Merged

refactor(events): Validate listeners #280

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2dff812
refactor(events): Validate listeners
Phoenix-Starlight Mar 17, 2024
47b5a99
refactor(events): Fix parameter validation
Phoenix-Starlight Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion src/main/java/com/seailz/discordjar/events/EventDispatcher.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,15 @@ public void addListener(DiscordListener... listeners) {
for (DiscordListener listener : listeners) {
for (Method method : listener.getClass().getMethods()) {
if (method.isAnnotationPresent(EventMethod.class)) {
Class<? extends Event> eventType = (Class<? extends Event>) method.getParameterTypes()[0];
Class<?> maybeEventType = method.getParameterTypes()[0];

if (!Event.class.isAssignableFrom(maybeEventType))
throw new IllegalArgumentException(String.format("%s first arg is not of Event", method));
else if (method.getParameterTypes().length > 1)
Phoenix-Starlight marked this conversation as resolved.
Show resolved Hide resolved
throw new IllegalArgumentException(String.format("%s#%s is an invalid listener", method.getDeclaringClass(), method.getName()));

@SuppressWarnings("unchecked")
Class<? extends Event> eventType = (Class<? extends Event>) maybeEventType;
EventMethod eventMethod = method.getAnnotation(EventMethod.class);

String customId = null;
Expand Down
Loading