Skip to content

Components v2: use valid JSON examples #7535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hackermondev
Copy link
Contributor

@hackermondev hackermondev commented Apr 30, 2025

None of these components have proper JSON examples. I'm not sure why, but I'm assuming it's not intentional.

@hackermondev hackermondev requested a review from a team as a code owner April 30, 2025 03:57
@hackermondev hackermondev requested review from anthonydiscord and removed request for a team April 30, 2025 03:57
@leymbda
Copy link
Contributor

leymbda commented Apr 30, 2025

I'd assume it was done that way to show that it belongs in payload's component field, but that isn't the main bit being demonstrated in the example. These updated ones are now showing examples of the full payload_json but are missing the component v2 flag, so if anything I think these are more wrong based on that. If it were to change, I think it'd make most sense to remove the components field entirely and just give the component itself (given that's what the example is supposed to be showing), but its fine as is imo

@hackermondev
Copy link
Contributor Author

@leymbda I think changing the examples just to show the inside of the components array makes the most sense here. I now understand what he was trying to do with the partial, but just having the dangling components field is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants