Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(interactions): support with_response query parameter in core #10512

Merged
merged 6 commits into from
Nov 17, 2024
Merged

feat(interactions): support with_response query parameter in core #10512

merged 6 commits into from
Nov 17, 2024

Conversation

monbrey
Copy link
Member

@monbrey monbrey commented Sep 18, 2024 •
edited by Jiralite
Loading

Please describe the changes this PR makes and why it should be merged:
#10499 but for /core

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)

@monbrey monbrey requested a review from a team as a code owner September 18, 2024 00:35
@vercel Vercel
Copy link

vercel bot commented Sep 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
discord-js ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2024 10:44pm
discord-js-guide ⬜️ Ignored (Inspect) Visit Preview Nov 17, 2024 10:44pm

@monbrey monbrey changed the title feat(InteractionResponses): support with_response query parameter in core feat(interactions): support with_response query parameter in core Sep 18, 2024
@monbrey monbrey mentioned this pull request Sep 18, 2024
Merged
kyranet
kyranet approved these changes Sep 22, 2024
View reviewed changes
packages/core/src/api/interactions.ts Outdated Show resolved Hide resolved
kyranet
kyranet previously requested changes Sep 22, 2024
View reviewed changes
Copy link
Member

@kyranet kyranet left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong button, sorry

almeidx
almeidx previously requested changes Sep 22, 2024
View reviewed changes
packages/core/src/api/interactions.ts Outdated Show resolved Hide resolved
packages/core/src/api/interactions.ts Outdated Show resolved Hide resolved
@monbrey monbrey force-pushed the with_response_core branch from 6391bf9 to d33d609 Compare November 9, 2024 22:07
@monbrey monbrey requested review from almeidx and kyranet November 9, 2024 22:09
@Jiralite Jiralite added this to the core 2.1.0 milestone Nov 9, 2024
@Jiralite Jiralite dismissed stale reviews from almeidx and kyranet November 10, 2024 09:31

Resolved.

kyranet
kyranet previously requested changes Nov 10, 2024
View reviewed changes
packages/core/src/api/interactions.ts Outdated Show resolved Hide resolved
@Jiralite Jiralite requested a review from kyranet November 15, 2024 13:56
@Jiralite Jiralite self-requested a review November 17, 2024 22:09
@kodiakhq kodiakhq bot merged commit 40fbd82 into discordjs:main Nov 17, 2024
7 checks passed
@Jiralite Jiralite modified the milestones: core 2.1.0, core 3.0.0 Dec 8, 2024
This was referenced Jan 3, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@Jiralite Jiralite Jiralite approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl iCrawl is a code owner automatically assigned from discordjs/core

@SpaceEEC SpaceEEC Awaiting requested review from SpaceEEC SpaceEEC is a code owner automatically assigned from discordjs/core

@almeidx almeidx Awaiting requested review from almeidx

Assignees
No one assigned
Labels
api support packages:core semver:minor
Projects
discord.js
Archived in project
Milestone
core 3.0.0
Development

Successfully merging this pull request may close these issues.
5 participants
@monbrey @vladfrangu @kyranet @Jiralite @almeidx