feat: add subscriptions #10541
Open
feat: add subscriptions #10541
+281
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
sdanialraza
force-pushed
the
feat/add-subscriptions-mainlib
branch
from
2401984
to
1d66e02
Compare
Jiralite
reviewed
Oct 26, 2024
Jiralite
reviewed
Oct 26, 2024
vladfrangu
previously requested changes
Nov 4, 2024
sdanialraza
force-pushed
the
feat/add-subscriptions-mainlib
branch
from
83fa2bf
to
cc694a9
Compare
Jiralite
previously requested changes
Nov 11, 2024
There was a problem hiding this comment.
According to the documentation1 and the specification2, ends_at may now be null. This means this logic needs to be modified as Date.parse(null) will result in NaN:
discord.js/packages/discord.js/src/structures/Entitlement.js
Lines 84 to 93 in f2f7f1f
I say this, but the entitlement object itself on the documentation does not have it marked as nullable. It probably needs updating (discord/discord-api-docs#7268).
Footnotes
sdanialraza
force-pushed
the
feat/add-subscriptions-mainlib
branch
from
cc694a9
to
5468dee
Compare
sdanialraza
force-pushed
the
feat/add-subscriptions-mainlib
branch
from
5468dee
to
ba472bd
Compare
Jiralite
previously requested changes
Nov 15, 2024
sdanialraza
force-pushed
the
feat/add-subscriptions-mainlib
branch
from
14b9f7b
to
13e69ca
Compare
Jiralite
approved these changes
Nov 22, 2024
Co-authored-by: Jiralite <[email protected]>
This reverts commit ba472bd.
sdanialraza
force-pushed
the
feat/add-subscriptions-mainlib
branch
from
13e69ca
to
080e537
Compare
Qjuh
suggested changes
Nov 24, 2024
| const Events = require('../../../util/Events'); | ||
|
|
||
| module.exports = (client, { d: data }) => { | ||
| const subscription = client.application.subscriptions.cache._add(data, false); |
There was a problem hiding this comment.
Suggested change
| const subscription = client.application.subscriptions.cache._add(data, false); | |
| const subscription = client.application.subscriptions._add(data, false); |
vladfrangu
approved these changes
Nov 25, 2024
Comment on lines
+45
to
+51
| this.currentPeriodStart = new Date(data.current_period_start); | ||
|
|
||
| /** | ||
| * The end of the current subscription period | ||
| * @type {Date} | ||
| */ | ||
| this.currentPeriodEnd = new Date(data.current_period_end); |
There was a problem hiding this comment.
Shouldn't this follow the same structure as the other timestamp fields?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Adds subscriptions for mainlib
Status and versioning classification: