feat(EntitlementManager): Support get entitlement #10606
Draft
+44
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
sdanialraza
suggested changes
Nov 20, 2024
| /** | ||
| * Options used to fetch an entitlement | ||
| * @typedef {BaseFetchOptions} FetchEntitlementOptions | ||
| * @property {EntitlementResolvable} entitlement The entitlement to fetch |
There was a problem hiding this comment.
Should this be EntitlementResolvable instead of just Snowflake? Doesn't make much sense to fetch an entitlement using itself
There was a problem hiding this comment.
I added this for consistency reasons (message fetching, event fetching, thread member fetching, etc.), but we can remove it if we feel strongly about it.
| async fetch({ limit, guild, user, skus, excludeEnded, cache = true, before, after } = {}) { | ||
| async fetch(options) { | ||
| if (!options) return this._fetchMany(options); | ||
| const { entitlement, cache, force } = options; |
There was a problem hiding this comment.
Suggested change
| const { entitlement, cache, force } = options; | |
| const { entitlement, cache = true, force } = options; |
| return this._add(data, cache); | ||
| } | ||
|
|
||
| async _fetchMany({ limit, guild, user, skus, excludeEnded, excludeDelete, cache, before, after } = {}) { |
There was a problem hiding this comment.
Shouldn't cache default to true as it was previously?
There was a problem hiding this comment.
It already is defaulted to true in _add(). Adding true here isn't actually doing anything.
Co-authored-by: Danial Raza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Status and versioning classification: