FEATURE: calendar integration, settings changes, and header icon button #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added integration with Discourse Chat to allow creating a link within the options of a chat window Open plain meeting links in a new browser tab rather than overwriting the current tab Added settings for the new chat button integration
Added integration with Discourse Chat to allow creating a link within the options of a chat window Open plain meeting links in a new browser tab rather than overwriting the current tab Added settings for the new chat button integration
Added integration with Discourse Chat to allow creating a link within the options of a chat window Open plain meeting links in a new browser tab rather than overwriting the current tab Added settings for the new chat button integration Separated template from javascript for better maintainability Added new settings for choose the default options in regards to iframes
|
@jacobtread I am guessing you are no longer working on this PR? |
|
No, I am no longer working on this. But I recall all the changes were all working and ready. Changes were made on behalf of someone else and I believe they hadn't decided quite what the direction for things were. If you're looking to get this merged though I can take this out of draft |
|
Thanks for your reply. Since you're no longer working on it, I will close it. No one on our side to maintain the changes. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Locations configuration
With the addition of all the new integrations and locations that Jitsi buttons can now be, a new setting "locations" was added to customize which ones are present:
Header icon button
Adds an optional icon that can be added to the header to open a quick jitsi link creation modal
Insert date/time
Adds a replacement modal for the "Insert date/time" toolbar button, when enabled through the
replace_date_timesetting the "Insert date/time" button will open a modified modal that allows inserting the date time as either a minimal calendar event with an optional Jitsi link: