FIX: Set topic subtype when embedding topics #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit registers a modifier to set the subtype of a topic to `Topic::POST_VOTING_SUBTYPE` during the embedding process when certain conditions are met: - a new topic is being created; - the topic will be saved to a valid category; - the category has either `create_as_post_voting_default` or `only_post_voting_in_this_category` set to `true`
markvanlan
approved these changes
Apr 5, 2024
plugin.rb
Outdated
| @@ -190,6 +190,20 @@ module ::PostVoting | |||
| false | |||
| end | |||
|
|
|||
| register_modifier(:topic_embed_import_create_args) do |args| | |||
| category_id = args[:category] | |||
| return args unless category_id | |||
There was a problem hiding this comment.
I kinda thought these returns had to be nexts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit registers a modifier to set the subtype of a topic to
Topic::POST_VOTING_SUBTYPEduring the embedding process when certain conditions are met:create_as_post_voting_defaultoronly_post_voting_in_this_categoryset totrueThis PR requires discourse/discourse#26527 to be merged in core. DO NOT MERGE before that.