lint fixes

.rubocop.yml

@@ -1,5 +1,5 @@
 inherit_gem:
-  rubocop-discourse: .rubocop.yml
+  rubocop-discourse: stree-compat.yml
 inherit_mode:
   merge:
     - Exclude

lib/message_bus.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
 
 require "monitor"
-require "set"
 
 require_relative "message_bus/version"
 require_relative "message_bus/message"
@@ -772,7 +771,7 @@ def global_subscribe_thread
         globals, locals, local_globals, global_globals = nil
 
         @mutex.synchronize do
-          return if @destroyed
+          return if @destroyed # rubocop:disable Lint/NonLocalExitFromIterator
           next unless @subscriptions
 
           globals = @subscriptions[nil]

lib/message_bus/backends/base.rb

@@ -48,7 +48,6 @@ module Backends
     #
     # @abstract
     class Base
-      # rubocop:disable Lint/UnusedMethodArgument
 
       # Raised to indicate that the concrete backend implementation does not implement part of the API
       ConcreteClassMustImplementError = Class.new(StandardError)

lib/message_bus/backends/postgres.rb

@@ -406,7 +406,7 @@ def global_subscribe(last_id = nil)
             on.message do |_c, m|
               if m == UNSUB_MESSAGE
                 @subscribed = false
-                return
+                return # rubocop:disable Lint/NonLocalExitFromIterator
               end
               m = MessageBus::Message.decode m
 

lib/message_bus/backends/redis.rb

@@ -300,7 +300,7 @@ def global_subscribe(last_id = nil, &blk)
               if m == UNSUB_MESSAGE
                 @subscribed = false
                 global_redis.unsubscribe
-                return
+                return # rubocop:disable Lint/NonLocalExitFromIterator
               end
               m = MessageBus::Message.decode m
 

message_bus.gemspec

@@ -35,6 +35,6 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'byebug'
   gem.add_development_dependency 'oj'
   gem.add_development_dependency 'yard'
-  gem.add_development_dependency 'rubocop-discourse'
+  gem.add_development_dependency 'rubocop-discourse', '3.8.1'
   gem.add_development_dependency 'rubocop-rspec'
 end

spec/lib/message_bus/multi_process_spec.rb

@@ -22,7 +22,7 @@ def work_it
       if msg.data == "done"
         bus.global_unsubscribe
       else
-        bus.publish("/response", "#{msg.data}-#{Process.pid.to_s}")
+        bus.publish("/response", "#{msg.data}-#{Process.pid}")
       end
     end
   ensure

spec/spec_helper.rb

@@ -19,7 +19,7 @@
 puts "Running with backend: #{CURRENT_BACKEND}"
 
 def test_only(*backends)
-  skip "Test doesn't apply to #{CURRENT_BACKEND}" unless backends.include?(CURRENT_BACKEND)
+  skip "Test doesn't apply to #{CURRENT_BACKEND}" if backends.exclude?(CURRENT_BACKEND)
 end
 
 def test_never(*backends)