Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes close_db_connection! deprecation warning #334

Merged
merged 2 commits into from
Aug 14, 2023
Merged

Removes close_db_connection! deprecation warning #334

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
75329d8
Removes close_db_connection! deprecation warning
kinduff May 25, 2023
8a2b99a
Updates CHANGELOG
kinduff Aug 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
FUTURE

- FIX: Typo in `group_ids_lookup` option name in Redis params exclusion list that was preventing the use of the redis backend along with this option.
- FIX: Removes close_db_connection! deprecation warning.

28-06-2023

Expand Down
4 changes: 3 additions & 1 deletion lib/message_bus/rack/middleware.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,9 @@ def close_db_connection!
# ConnectionManagement in Rails puts a BodyProxy around stuff
# this means connections are not returned until rack.async is
# closed
if defined? ActiveRecord::Base.clear_active_connections!
if defined? ActiveRecord::Base.connection_handler
ActiveRecord::Base.connection_handler.clear_active_connections!
elsif defined? ActiveRecord::Base.clear_active_connections!
ActiveRecord::Base.clear_active_connections!
end
end
Expand Down
Loading