Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better default values #287

Merged
merged 11 commits into from
Jan 26, 2022
Merged

Better default values #287

merged 11 commits into from
Jan 26, 2022

Conversation

jswift-stfc
Copy link
Contributor

PR to implement default values for a range of attributes/parameters. Feedback would be good for those attributes that do not have default values / on the default values that have been set.

@jswift-stfc jswift-stfc added the scripting python scripts label Jan 24, 2022
@jswift-stfc jswift-stfc self-assigned this Jan 24, 2022
Copy link
Member

@trisyoungs trisyoungs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff. Some additional features will come out of this and can be captured as separate issues.

src/gudrun_classes/container.py Show resolved Hide resolved
src/gudrun_classes/container.py Outdated Show resolved Hide resolved
src/gudrun_classes/sample.py Show resolved Hide resolved
src/gudrun_classes/sample.py Outdated Show resolved Hide resolved
@jswift-stfc jswift-stfc mentioned this pull request Jan 26, 2022
@jswift-stfc jswift-stfc merged commit 618a1f6 into main Jan 26, 2022
@jswift-stfc jswift-stfc deleted the better-default-values branch January 26, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scripting python scripts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants