Send Dispatch ID with RunRequest #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achille-roussel
approved these changes
Apr 17, 2024
This was referenced Apr 17, 2024
chriso
added a commit
that referenced
this pull request
Apr 17, 2024
In #24 we added `RunRequest.dispatch_id`, to allow clients to link requests back to a particular call dispatch. When a function calls other functions via `Poll`, clients have no way to link the children back to their parent calls. This PR adds additional fields that allow clients to reconstruct the call hierarchy as requests are handled. I've explicitly left out a `PollResult.dispatch_ids`, so that there's no confusion between the usage of these identifiers vs. the correlation IDs that users currently use to link call results back to their original calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When function calls are dispatched through a
DispatchService, the service returns adispatch_idfor each call.This identifier is never shown again to the user; they have no way of knowing which requests correspond to that function call.
This PR resolves the issue by attaching the same
dispatch_idto eachRunRequest.