Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing images so we can run the app locally #453

Merged
merged 2 commits into from
Jun 8, 2021
Merged

Conversation

codyseibert
Copy link
Collaborator

@codyseibert codyseibert commented Jun 6, 2021

depends on #453, don't merge this until the API PR is deployed.

#454

Well detailed description of the change :

When trying to connect the UI to a locally running mumble api, the image were not loading correctly. This change wraps all images in a getImageUrl function so we can abstract where those images are located.

Type of change :

  • Bug fix

  • New feature

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the STYLE_GUIDE of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • All new and existing tests passed.

Reviewers

@vercel
Copy link

vercel bot commented Jun 6, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/divanov11/mumble/FyvHtCJY1exUzx9Ywza1sQ65Brye
✅ Preview: https://mumble-git-fixingupvotes-divanov11.vercel.app

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants