Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a timeout for Named Pipe connection to the Pahkat Service #50 #53

Merged
merged 1 commit into from
May 23, 2023

Conversation

alvskar
Copy link
Contributor

@alvskar alvskar commented May 16, 2023

To help with #50

This is intended to add a 2s timeout for the connection to the Pahkat Service Named Pipe and an associated message box informing the user that the Windows Service is down if the connection fails, and then closing the program (same as what appears to be intended startup behavior but that code was never hit).

This may not address #50 completely depending on what the cause is, but I have not been able to replicate the issue otherwise. Currently, if the Windows Service is down, Divvun Manager just waits forever, on the All Repositories page or any other relevant page since there's never any cancellation information sent. This change should help narrow down if the issue is related to that.

@alvskar
Copy link
Contributor Author

alvskar commented May 17, 2023

This might also be relevant to #15 and #17 , seem to be a string of issues around UI and Windows Service race conditions.

@divvun-taskcluster
Copy link

Uh oh! Looks like an error! Details

Task RvUKImUASRKBUs5hdb66ug can't be rescheduled past its deadline of 2023-05-17T12:46:14.099Z.


  • method: rerunTask
  • errorCode: RequestConflict
  • statusCode: 409
  • time: 2023-05-17T13:18:20.373Z

@alvskar alvskar force-pushed the feature/pahkat-rpc-timeout branch from e9298aa to d18315d Compare May 22, 2023 10:32
@alvskar alvskar merged commit ece0af9 into main May 23, 2023
@alvskar alvskar deleted the feature/pahkat-rpc-timeout branch May 30, 2023 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants