fix: Some id were localized in the templates #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1350 +/- ##
=======================================
Coverage 72.39% 72.39%
=======================================
Files 72 72
Lines 3268 3268
Branches 532 532
=======================================
Hits 2366 2366
Misses 735 735
Partials 167 167 |
vinitkumar
approved these changes
Jun 5, 2023
ivarsg
reviewed
Jun 5, 2023
There was a problem hiding this comment.
In order to solve issue #1335, I propose to use string literal within JavaScript code instead of integer literal. In case if PK value exceeds JavaScript Number.MAX_SAFE_INTEGER value, integer literal will be rounded, thus value passed to the target function will be different from the actual PK value.
filer/templates/admin/filer/folder/directory_thumbnail_list.html
Outdated
Show resolved
Hide resolved
filer/templates/admin/filer/folder/directory_thumbnail_list.html
Outdated
Show resolved
Hide resolved
Co-authored-by: ivarsg <[email protected]>
Co-authored-by: ivarsg <[email protected]>
Co-authored-by: ivarsg <[email protected]>
Co-authored-by: ivarsg <[email protected]>
|
@ivarsg Wow, you really push the database! |
marksweb
approved these changes
Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes issue #1335.
A similar change has been merged into django cms core (django-cms/django-cms#7188)
Related resources
Checklist
masterSlack to find a “pr review buddy” who is going to review my pull request.