-
Notifications
You must be signed in to change notification settings - Fork 583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Image dimensions update management command #1434
Conversation
I guess I am doing too much work here. It would probably better to call some helper function of filer? Change a field, call save(), and thus triggering calculation of _width and _height (and possibly other meta fields). Also, my test fails, probalby because the provided JPG is not a real one? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benzkji Two little things (which I might be wrong about).
@benzkji I would be fine if you caught the |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1434 +/- ##
==========================================
+ Coverage 76.43% 76.59% +0.15%
==========================================
Files 75 75
Lines 3514 3546 +32
Branches 562 568 +6
==========================================
+ Hits 2686 2716 +30
- Misses 666 667 +1
- Partials 162 163 +1
☔ View full report in Codecov by Sentry. |
probably last thing: test with SVG, and "corrupt" SVG. |
@benzkji I think, also a SVG-based test would be great. Here's a way to easily test SVGs: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @benzkji ! Thanks so much!
Description
Basic management command, to insert missing image dimensions.
I've added a test, but can't find instructions on how to setup local tests.
Also, I've only seen conventional commits just now...so...
master
Slack to find a “pr review buddy” who is going to review my pull request.