Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for on_delete requirement in Filer fields for Django 5.1 #1508

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

sourcery-ai[bot]
Copy link
Contributor

@sourcery-ai sourcery-ai bot commented Nov 19, 2024

Resolves #1506

Update documentation to reflect the requirement of the on_delete parameter for FilerFileField and FilerImageField, ensuring compatibility with Django 5.1.

Documentation:

  • Update documentation to indicate that the on_delete parameter is required when using FilerFileField and FilerImageField.
  • Add example code in the documentation showing proper field definition with the on_delete parameter.
  • Review and update other field examples in the documentation to ensure they include required parameters.

This PR was automatically generated.

If you want to make changes to this PR:

  • Leave a review and I'll make the changes
  • Leave a comment with the changes you want to see
  • Push commits to the branch

Update documentation to reflect the requirement of the `on_delete` parameter for `FilerFileField` and `FilerImageField`, ensuring compatibility with Django 5.1.

Documentation:
- Update documentation to indicate that the `on_delete` parameter is required when using `FilerFileField` and `FilerImageField`.
- Add example code in the documentation showing proper field definition with the `on_delete` parameter.
- Review and update other field examples in the documentation to ensure they include required parameters.

Resolves #1506
@sourcery-ai sourcery-ai bot requested a review from fsbraun November 19, 2024 16:01
Copy link
Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sourcery-ai
Bump the version to 3.3.0 and update the changelog

@django-cms django-cms deleted a comment from sourcery-ai bot Nov 19, 2024
@fsbraun fsbraun merged commit 8f7f96f into master Nov 19, 2024
66 checks passed
@fsbraun fsbraun deleted the sourcery-ai/issue-1506 branch November 19, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to use django-filer from following docs
1 participant